Minor Build Correction

Made a cool mod to CEF that you'd like to share with others? Discuss CEF modifications here, and view modifications that others have made.

Minor Build Correction

Postby Moonbase » Thu May 25, 2023 5:57 am

Hi

In cef_ref_counted.h there is the following at line 195 (current release).

#if DCHECK_IS_ON()
~RefCountedThreadSafeBase();

This leaves the the destructor without a body as it is not defined anywhere else.

Might I suggest,

#if DCHECK_IS_ON()
~RefCountedThreadSafeBase() {}

I can create a patch for this but I'm not familiar with the style of the code so what I have suggested may not be correct.

Moonbase
Moonbase
Newbie
 
Posts: 5
Joined: Wed May 24, 2023 4:29 am

Re: Minor Build Correction

Postby magreenblatt » Thu May 25, 2023 6:05 am

I think this is intentional. See viewtopic.php?f=6&t=18694
magreenblatt
Site Admin
 
Posts: 12357
Joined: Fri May 29, 2009 6:57 pm


Return to Modifications Forum

Who is online

Users browsing this forum: No registered users and 2 guests