Page 1 of 1

Minor Build Correction

PostPosted: Thu May 25, 2023 5:57 am
by Moonbase
Hi

In cef_ref_counted.h there is the following at line 195 (current release).

#if DCHECK_IS_ON()
~RefCountedThreadSafeBase();

This leaves the the destructor without a body as it is not defined anywhere else.

Might I suggest,

#if DCHECK_IS_ON()
~RefCountedThreadSafeBase() {}

I can create a patch for this but I'm not familiar with the style of the code so what I have suggested may not be correct.

Moonbase

Re: Minor Build Correction

PostPosted: Thu May 25, 2023 6:05 am
by magreenblatt
I think this is intentional. See viewtopic.php?f=6&t=18694