Page 1 of 1

Allow synchronously sending extra_info to renderer

PostPosted: Wed Feb 14, 2018 11:23 am
by petersmulovics

My team created a PR at, for which we would like to ask for help to review.

What is the problem it solves? It does allow you to synchronously send extra_info to renderer at each browser creation. As a result, this allows you to solve the problem raised at What does that issue focuses on?

This allows language wrappers to register objects that would be synchronously available at the window creation, e.g. you could register objects for scripting that would work even when the window is navigated between domains (one of the basic usecases this solves is logging in using SSO in those windows - most of the SSO solutions involve a 'dance' to and fro on a SSO domain).

So please, if possible, provide feedback on the PR to make it more feasible to have it merged in the future,

Thank you,

Re: Allow synchronously sending extra_info to renderer

PostPosted: Mon Feb 19, 2018 8:17 am
by Czarek
The reviewing process before PR is accepted can take some time. It usually requires substantial amount of work from the reviewer to make sure code quality is high and it doesn't cause any side issues. You will have to be patient and wait until Marshall finds time. He is the only one that can merge PRs currently.