Initial patch to enable building Cef using local mirrors

Made a cool mod to CEF that you'd like to share with others? Discuss CEF modifications here, and view modifications that others have made.

Initial patch to enable building Cef using local mirrors

Postby grossag » Tue Nov 10, 2015 11:20 am

I attached the patch and description to this issue https://bitbucket.org/chromiumembedded/ ... -downloads then realized that it should have gone here. Here is the description:

I am getting pretty far in the process and am hoping to submit a few changes to the active branches (master and 2526?). I have attached a patch (script_changes.diff) that contains my recent changes but am not sure how best to send it out for review; the patch is relative to branch 2526. I also apologize that the patch contains a combination of different changes rolled into one diff. The changes are:

  • Changes cmake requirement from 2.8.12.2 to 2.8.12.1. That happens to be what we have internally and it has worked well for me. Please let me know if there are any extra factors that specifically required 2.8.12.2.
  • New automate-git.py command-line arguments:
    --chromium-url: Allows overriding the synced Chromium URL
    --no-cef-update: Allows bypassing the step to sync cef. Internally we use it as a git submodule for build reproducibility.
    --no-depot-tools-update: Allows bypassing the step to update depot_tools. Again we use this as a git submodule for build reproducibility.
    --distrib-subdir: Allows specifying the subdirectory name of chromium/src/cef/binary_distrib. Currently make_distrib.py creates a very specific directory name that is difficult for our scripts to parse and I wanted to bypass this.
  • Support in make_distrib.py for --distrib-subdir.

That last "--distrib-subdir" is one that I want to explain a bit more because I'm not sure I'm doing it the best way. The problem is that right now the scripts create a subdirectory named, for example on branch 2454, "cef_binary_3.2454.0.gUnknown_windows32". Our build then needs to extract that folder to a staging directory that is consumed by other components. I have found that my scripts are a lot easier to understand if I override that subdir name to something more static, like "cef-package".

This works for us because we only build either debug or release builds and only x86, so there is no conflict between multiple folders. But I am wondering if it would be better if I just add a simpler command-line arg like "--use-basic-distribdir-name". In this case make_distrib.py can do something like "cef-package-[debug,release]-[x86,x64]". This would still work for our purposes but would make it more future-proof if building multiple configurations.
Attachments
script_changes.txt
Patch with initial changes relative to branch 2526
(7.57 KiB) Downloaded 538 times
grossag
Techie
 
Posts: 17
Joined: Thu Oct 01, 2015 9:39 am

Re: Initial patch to enable building Cef using local mirrors

Postby magreenblatt » Tue Nov 10, 2015 2:40 pm

Thanks, I responded in the issue.
magreenblatt
Site Admin
 
Posts: 9831
Joined: Fri May 29, 2009 6:57 pm


Return to Modifications Forum

Who is online

Users browsing this forum: No registered users and 1 guest