Call OnTitleChange even if the title hasn't changed

[dshaulov]

Hi,

Currently, when CEF gets a notification for a title change, it checks if it is the same as the current title, and doesn't notify the client if it is.
This is happening in CefBrowserHostImpl::Observe.
Can this check be removed?

The check leads to strange cases where if we load a different page - we do not get even one notification for title change for the new url.
So if we clear the title between loads - we have no "OnTitleChange" that puts it back.
If anyone needs the check - it can be easily done on the client.

Thanks, Daniel.

[magreenblatt]

What CEF version? Why do you clear the title between loads?

[dshaulov]

CEF3 - (almost) latest trunk.

By clear the title I mean UI-wise, We just show "Loading..." during the load.
We do not do anything CEF-related to clear it (should we? can we?).

[dshaulov]

So.. can/should I create an issue with a patch for this?

[magreenblatt]

So.. can/should I create an issue with a patch for this?

Feel free to create an issue. We can use any stars that accumulate to judge the popularity of this change.

[dshaulov]

Issue and patch submitted:
https://code.google.com/p/chromiumembed ... il?id=1062

[Czarek]

Have you considered changing icon instead of title during loading? This is how browsers do it.

[dshaulov]

Have you considered changing icon instead of title during loading? This is how browsers do it.

This not really a solution..
Changing UI because of small technical reasons (deleting 2 lines of code) is not OK.