Building v119 (branch 6045) fails

[callum]

A fix for the partition_allocator error (add the necessary include) could also be submitted to Chromium.

Happy to submit a fix of course but I assumed this must be my system configuration - countless groups/people already build Chromium and CEF including the Spotify build bots - surely they would have hit the same error if the build was broken?

[magreenblatt]

A fix for the partition_allocator error (add the necessary include) could also be submitted to Chromium.

Happy to submit a fix of course but I assumed this must be my system configuration - countless groups/people already build Chromium and CEF including the Spotify build bots - surely they would have hit the same error if the build was broken?

Required headers should be explicitly included. Otherwise, you’re just depending on luck to get the include transitively. https://google.github.io/styleguide/cpp ... at_You_Use

[magreenblatt]

countless groups/people already build Chromium and CEF including the Spotify build bots

Chromium builds using bundled clang and libc++. The CEF sandbox target builds with MSVC libc++ for compatibility with client apps. That makes the sandbox target more fragile (depends on the MSVC version), and it’s not uncommon to find bugs (in code or MSVC) that just happen to compile OK with clang.

[callum]

Thank you for the clarification - I submitted a report via crbug.com (https://bugs.chromium.org/p/chromium/is ... id=1503397)

[magreenblatt]

Thank you for the clarification - I submitted a report via crbug.com (https://bugs.chromium.org/p/chromium/is ... id=1503397)

Thanks for reporting. The issue has now been fixed in Chromium (likely in M121+).