Page 1 of 1

cefclient build fails (CEF 94.2.2)

PostPosted: Tue Sep 21, 2021 12:59 am
by naoki5
I downloaded binary distribution (cef_binary_94.2.2+g0c2cc26+chromium-94.0.4606.50_windows32_beta.tar.bz2) and built it with VS 2019.
The cefclient build fails.
There seems to be a problem with the switch statement.
Code: Select all
>E:\projects\cef_binary\tests\cefclient\browser\views_overlay_controls.cc(32): error C2220: 次の警告はエラーとして処理されます
>E:\projects\cef_binary\tests\cefclient\browser\views_overlay_controls.cc(32): warning C4715: 'client::`anonymous namespace'::GetLabel': 値を返さないコントロール パスがあります。

Re: cefclient build fails (CEF 94.2.2)

PostPosted: Tue Sep 21, 2021 4:35 am
by magreenblatt
Thanks, I'll fix this shortly.

Re: cefclient build fails (CEF 94.2.2)

PostPosted: Tue Sep 21, 2021 4:44 am
by magreenblatt
Here's the fix, if you want to apply it locally:
Code: Select all
diff --git tests/cefclient/browser/views_overlay_controls.cc tests/cefclient/browser/views_overlay_controls.cc
index 0945a791c..9421bb415 100644
--- tests/cefclient/browser/views_overlay_controls.cc
+++ tests/cefclient/browser/views_overlay_controls.cc
@@ -29,6 +29,8 @@ std::string GetLabel(ViewsOverlayControls::Command command, bool maximized) {
     case ViewsOverlayControls::Command::kClose:
       return "X";
   }
+  NOTREACHED();
+  return std::string();
 }

 }  // namespace

Re: cefclient build fails (CEF 94.2.2)

PostPosted: Tue Sep 21, 2021 5:01 am
by naoki5
I have successfully built cefclient and was able to launch it.
Thanks.

Re: cefclient build fails (CEF 94.2.2)

PostPosted: Tue Sep 21, 2021 5:30 am
by magreenblatt