Error compiling a unit test on macOS for CEF 80.1.2+g9d2a31e

[callum]

When I build CEF 80.1.2+g9d2a31e and all the associated tests on macOS 10.14, there is an error building osr_display_unittest.cc because the file does not have a new line at the end.

Code: Select all

cef_binary_80.1.2+g9d2a31e+chromium-80.0.3987.149_macosx64/tests/ceftests/osr_display_unittest.cc:393:2: error:
no newline at end of file [-Werror,-Wnewline-eof]

This is what I do to build:

Code: Select all

mkdir build
cd build
cmake -G "Xcode" -DPROJECT_ARCH="x86_64" ..
xcodebuild -project cef.xcodeproj -configuration Release


(cmake version 3.14.5, xcode version 11.3.1)

Obviously trivial to fix but I wondered if this indicates I am doing something wrong since I assume that these tests are built all the time for official distributions.

FWIW, I first encountered this with my own build of Chromium + media codecs then CEF but I checked and it also behaves the same way with the CEF pre-built version I downloaded from the Spotify open source site.

[magreenblatt]

These warnings tend to become stricter with newer Xcode/clang versions. We generally only see the warnings for the tools versions bundled with Chromium or specified on the BranchesAndBuilding Wiki. You're welcome to file issues or submit fixes as you discover them.