cef crash when closing

[yong018wu]

Hi Expert,
In cefclient sample, close browser should be better to TryClose or Close(false), then give cef second chance the close the browser. but it's not easy to do that in my complex windows project. So I simply close it with Close(true). Does that has side effect?
I have a crash that happened when message router remove the handler, I remove the handler in OnBeforeClose, here's the crash stack, do you have ever met this kind of crash, or give me some tip, if something I did wrong.



05bcf5b8 60a18ff4 1c17daa8 ffffffff 05bcf58c cefwrapper!`anonymous namespace'::CefMessageRouterBrowserSideImpl::SendQueryFailure+0x4a [d:\cef\prebuilt\cef_binary_76.1.9+g2cf916e+chromium-76.0.3809.87_windows32\libcef_dll\wrapper\cef_message_router.cc @ 436]
02 05bcf5f0 60a1b88c 000037de 00000000 1c17daa8 cefwrapper!`anonymous namespace'::CefMessageRouterBrowserSideImpl::CancelQuery+0x54 [d:\cef\prebuilt\cef_binary_76.1.9+g2cf916e+chromium-76.0.3809.87_windows32\libcef_dll\wrapper\cef_message_router.cc @ 469]
03 05bcf61c 60a1a7cd 0000000d 000037de 00000000 cefwrapper!``anonymous namespace'::CefMessageRouterBrowserSideImpl::CancelPendingFor'::`2'::Visitor::OnNextInfo+0x4c [d:\cef\prebuilt\cef_binary_76.1.9+g2cf916e+chromium-76.0.3809.87_windows32\libcef_dll\wrapper\cef_message_router.cc @ 510]
04 05bcf664 60a18f62 05bcf67c 13f9d292 00000001 cefwrapper!CefBrowserInfoMap<__int64,`anonymous namespace'::CefMessageRouterBrowserSideImpl::QueryInfo *,DefaultCefBrowserInfoMapTraits<`anonymous namespace'::CefMessageRouterBrowserSideImpl::QueryInfo *> >::FindAll+0x7d [d:\cef\prebuilt\cef_binary_76.1.9+g2cf916e+chromium-76.0.3809.87_windows32\libcef_dll\wrapper\cef_browser_info_map.h @ 122]
05 05bcf6a4 60a1c62b 00000000 32c85ca0 00000001 cefwrapper!`anonymous namespace'::CefMessageRouterBrowserSideImpl::CancelPendingFor+0x122 [d:\cef\prebuilt\cef_binary_76.1.9+g2cf916e+chromium-76.0.3809.87_windows32\libcef_dll\wrapper\cef_message_router.cc @ 530]
06 05bcf6d0 609fd637 32c85d80 13f9d2ca 05bcf74c cefwrapper!`anonymous namespace'::CefMessageRouterBrowserSideImpl::RemoveHandler+0xeb [d:\cef\prebuilt\cef_binary_76.1.9+g2cf916e+chromium-76.0.3809.87_windows32\libcef_dll\wrapper\cef_message_router.cc @ 165]
07 05bcf6fc 60a2eb91 3c4ce020 13f9d316 374ff9c8 cefwrapper!CefWrapper::ClientHandler::OnBeforeClose+0x47 [j:\jabber\products\jabber-win\src\cefwrapper\src\clienthandler.cpp @ 702]

By they way, the close mechanism is so ugly.

[Czarek]

It's a DEBUG CHECK in message router. You should receive a process message in renderer with error code and error message, see: https://github.com/chromiumembedded/cef ... er.cc#L440

Test with latest CEF v79.

[nickak2003]

I was doing OSR and I ended up doing this to close the system, idk if it is the right way, but it differs drastically from the demos:
In this code there is only one browser but I imagine it could work with more.

Code: Select all

    void CloseAllBrowsers(bool force_close) {


        mBrowser->GetHost()->TryCloseBrowser();
       
        while (!mBrowser->HasOneRef()) {
            CefDoMessageLoopWork();
        }

        mBrowser = NULL;
    }
    bool DoClose(CefRefPtr<CefBrowser> browser) {
        CEF_REQUIRE_UI_THREAD();

        return false;
    }
    virtual void OnBeforeClose(CefRefPtr<CefBrowser> browser) override {

        CEF_REQUIRE_UI_THREAD();
    }



[Czarek]

You're having an issue with message router. Read documentation in cef_message_router.h and if that's not enough to understand what you're doing wrong see also code comments in cef_message_router.cc. If you're sending an inter-process message during browser closing then it might fail if for example the renderer process doesn't exist anymore.