cef3 multi-window concurrency bug (windows)

[andybrown]

CefJavaScriptDialog installs a windows message hook around its call to a modal ShowWindow() call to show a javascript dialog.

The bug is that javascript running in a second window can cause another entry into CefJavaScriptDialog while the first dialog is on display which will cause DCHECK(msg_hook_ == NULL) to fail in InstallMessageHook().

I was under the impression that v8 was executing once in each window process so this shouldn't happen but it looks like it's talking back to the browser host to display alerts.

Is there any reason why the HHOOK variable is a global and not a member of CefJavaScriptDialog?

[magreenblatt]

The message hook is global to the current thread (not tied to a particular window). We need to change the implementation so that the hook is unregistered after all CefJavaScriptDialog objects have been destroyed. Please add an issue to the CEF issue tracker.

[andybrown]

Please add an issue to the CEF issue tracker.

Done, thanks.