Page 1 of 1

Compilation flags for the spotify nigthly build

PostPosted: Thu Oct 17, 2019 12:24 pm
by tgayet
Hi,

I have seen nightly build available here :
http://opensource.spotify.com/cefbuilds/index.html

Then I have seen the following page that detail the build :
https://bitbucket.org/chromiumembedded/ ... figuration

And i wanna be sure onthe the folling flags are used for the spotify build :
export GN_DEFINES="is_official_build=true use_sysroot=true use_allocator=none symbol_level=1"

Can you confirm that point or detail the complete list of the flags used.

Thanks in advance.

BR
Thierry

Re: Compilation flags for the spotify nigthly build

PostPosted: Thu Oct 17, 2019 1:14 pm
by Czarek
These are args for Linux for use with the automate-git.py script. If you want to know all GN args that are being set by CEF then see the gn_args.py script: https://bitbucket.org/chromiumembedded/ ... gn_args.py

Re: Compilation flags for the spotify nigthly build

PostPosted: Fri Oct 18, 2019 6:29 am
by tgayet
hi,

Okay thanks but what I wanted to know was the list of flags used for downloadable builds from spotify (http://opensource.spotify.com/cefbuilds/index.html)?

Are there only these flags: "is_official_build = true use_sysroot = true use_allocator = none symbol_level = 1" or are there others passed but not detailed?

Thanks in advance.

Re: Compilation flags for the spotify nigthly build

PostPosted: Fri Oct 18, 2019 6:33 am
by Czarek
Yes, Spotify builds use configuration from that wiki page.

Re: Compilation flags for the spotify nigthly build

PostPosted: Fri Oct 18, 2019 6:40 am
by Czarek
I see that Marshall has just updated the flags for Linux 64-bit on the wiki page:
Code: Select all
export GN_DEFINES="is_official_build=true use_sysroot=true use_allocator=none symbol_level=1 is_cfi=false use_thin_lto=false"

Re: Compilation flags for the spotify nigthly build

PostPosted: Fri Oct 18, 2019 6:47 am
by tgayet
yes my target is x86_64.

Thanks for the confirmation !

Re: Compilation flags for the spotify nigthly build

PostPosted: Fri Oct 18, 2019 6:50 am
by magreenblatt

Re: Compilation flags for the spotify nigthly build

PostPosted: Fri Oct 18, 2019 6:58 am
by Czarek
@Marshall What do you think of providing build logs for each Spotify build that was created? For example downloadable as .tar.gz file or so along with other binary files.

Re: Compilation flags for the spotify nigthly build

PostPosted: Fri Oct 18, 2019 7:02 am
by magreenblatt
Czarek wrote:@Marshall What do you think of providing build logs for each Spotify build that was created? For example downloadable as .tar.gz file or so along with other binary files.

I'm not sure what value this would provide, beyond catching the occasional Wiki documentation error?