Missing SSL_CONNECTION_VERSION_TLS1_3 (3729 branch)

Do not post support requests, bug reports or feature requests. Discuss CEF here. Non-CEF related discussion goes in General Discussion!

Missing SSL_CONNECTION_VERSION_TLS1_3 (3729 branch)

Postby ndesktop » Fri May 31, 2019 3:41 am

I'm looking in cef_types and I noticed that SSL_CONNECTION_VERSION_TLS1_3 is missing.
Code: Select all
// Supported SSL version values. See net/ssl/ssl_connection_status_flags.h
// for more information.
typedef enum {
  SSL_CONNECTION_VERSION_UNKNOWN = 0,  // Unknown SSL version.
  SSL_CONNECTION_VERSION_SSL2 = 1,
  SSL_CONNECTION_VERSION_SSL3 = 2,
  SSL_CONNECTION_VERSION_TLS1 = 3,
  SSL_CONNECTION_VERSION_TLS1_1 = 4,
  SSL_CONNECTION_VERSION_TLS1_2 = 5,
  // Reserve 6 for TLS 1.3.
  SSL_CONNECTION_VERSION_QUIC = 7,
} cef_ssl_version_t;


Inside net/\ssl/ssl_connection_status_flags.h, though, it is defined:
Code: Select all
enum SSLVersion {
  SSL_CONNECTION_VERSION_UNKNOWN = 0,  // Unknown SSL version.
  SSL_CONNECTION_VERSION_SSL2 = 1,
  SSL_CONNECTION_VERSION_SSL3 = 2,
  SSL_CONNECTION_VERSION_TLS1 = 3,
  SSL_CONNECTION_VERSION_TLS1_1 = 4,
  SSL_CONNECTION_VERSION_TLS1_2 = 5,
  SSL_CONNECTION_VERSION_TLS1_3 = 6,
  SSL_CONNECTION_VERSION_QUIC = 7,
  SSL_CONNECTION_VERSION_MAX,
};


Is there a reason for this?

Edit: SSL constants were added in 10c1fd6b (9/2/2016), when TLS 1.3 was not defined (RFC 8446 become available in August 2018).
Now I think it can be added.
ndesktop
Expert
 
Posts: 366
Joined: Thu Dec 03, 2015 10:10 am

Re: Missing SSL_CONNECTION_VERSION_TLS1_3 (3729 branch)

Postby magreenblatt » Fri May 31, 2019 3:48 am

The enumeration should be updated. Please add a bug, and a PR would be welcome.
magreenblatt
Site Admin
 
Posts: 9836
Joined: Fri May 29, 2009 6:57 pm

Re: Missing SSL_CONNECTION_VERSION_TLS1_3 (3729 branch)

Postby ndesktop » Mon Jun 03, 2019 2:50 am

Sorry about the delay.
Issue 2669 here, PR here.
ndesktop
Expert
 
Posts: 366
Joined: Thu Dec 03, 2015 10:10 am


Return to CEF Discussion

Who is online

Users browsing this forum: No registered users and 5 guests