Page 1 of 1

Where would I submit a patch?

PostPosted: Sun Oct 14, 2018 9:31 am
by kabone76
Hello all,


I recently made a patch to support disabling webrtc in branch 3538. Where would I need to submit this?

Re: Where would I submit a patch?

PostPosted: Sun Oct 14, 2018 11:17 am
by milannn
Please tell me how you build cef for desabled webrtc. preferably detailed.

Re: Where would I submit a patch?

PostPosted: Sun Oct 14, 2018 1:19 pm
by magreenblatt
Such a patch should be submitted to Chromium. See https://groups.google.com/a/chromium.or ... yjcoAGEQAJ

Re: Where would I submit a patch?

PostPosted: Sun Oct 14, 2018 1:19 pm
by ndesktop
I think you should create an issue and submit a PR.

Re: Where would I submit a patch?

PostPosted: Sun Oct 14, 2018 1:21 pm
by ndesktop
magreenblatt wrote:Such a patch should be submitted to Chromium. See https://groups.google.com/a/chromium.or ... yjcoAGEQAJ

Cannot be somehow parametrized in settings and using an entry in patch/ ?

Re: Where would I submit a patch?

PostPosted: Sun Oct 14, 2018 1:57 pm
by magreenblatt
This is not something that we would accept as a patch for the CEF project. It should be fixed in Chromium.

Re: Where would I submit a patch?

PostPosted: Sun Oct 14, 2018 6:53 pm
by kabone76
magreenblatt wrote:Such a patch should be submitted to Chromium. See https://groups.google.com/a/chromium.or ... yjcoAGEQAJ

Thanks I will check this out.

milannn wrote:Please tell me how you build cef for desabled webrtc. preferably detailed.

Are you looking to disable it? The patch is only for linux right now. I am working on getting a windows patch should be ready tomorrow..

Re: Where would I submit a patch?

PostPosted: Tue Oct 16, 2018 4:35 pm
by milannn
kabone76 wrote:
magreenblatt wrote:Such a patch should be submitted to Chromium. See https://groups.google.com/a/chromium.or ... yjcoAGEQAJ

Thanks I will check this out.

milannn wrote:Please tell me how you build cef for desabled webrtc. preferably detailed.

Are you looking to disable it? The patch is only for linux right now. I am working on getting a windows patch should be ready tomorrow..


Any news on the build for windows?