Where would I submit a patch?

Do not post support requests, bug reports or feature requests. Discuss CEF here. Non-CEF related discussion goes in General Discussion!

Where would I submit a patch?

Postby kabone76 » Sun Oct 14, 2018 9:31 am

Hello all,


I recently made a patch to support disabling webrtc in branch 3538. Where would I need to submit this?
kabone76
Techie
 
Posts: 19
Joined: Wed Oct 03, 2018 6:36 pm

Re: Where would I submit a patch?

Postby milannn » Sun Oct 14, 2018 11:17 am

Please tell me how you build cef for desabled webrtc. preferably detailed.
milannn
Newbie
 
Posts: 4
Joined: Sun Oct 14, 2018 11:03 am

Re: Where would I submit a patch?

Postby magreenblatt » Sun Oct 14, 2018 1:19 pm

Such a patch should be submitted to Chromium. See https://groups.google.com/a/chromium.or ... yjcoAGEQAJ
magreenblatt
Site Admin
 
Posts: 12382
Joined: Fri May 29, 2009 6:57 pm

Re: Where would I submit a patch?

Postby ndesktop » Sun Oct 14, 2018 1:19 pm

I think you should create an issue and submit a PR.
ndesktop
Master
 
Posts: 750
Joined: Thu Dec 03, 2015 10:10 am

Re: Where would I submit a patch?

Postby ndesktop » Sun Oct 14, 2018 1:21 pm

magreenblatt wrote:Such a patch should be submitted to Chromium. See https://groups.google.com/a/chromium.or ... yjcoAGEQAJ

Cannot be somehow parametrized in settings and using an entry in patch/ ?
ndesktop
Master
 
Posts: 750
Joined: Thu Dec 03, 2015 10:10 am

Re: Where would I submit a patch?

Postby magreenblatt » Sun Oct 14, 2018 1:57 pm

This is not something that we would accept as a patch for the CEF project. It should be fixed in Chromium.
magreenblatt
Site Admin
 
Posts: 12382
Joined: Fri May 29, 2009 6:57 pm

Re: Where would I submit a patch?

Postby kabone76 » Sun Oct 14, 2018 6:53 pm

magreenblatt wrote:Such a patch should be submitted to Chromium. See https://groups.google.com/a/chromium.or ... yjcoAGEQAJ

Thanks I will check this out.

milannn wrote:Please tell me how you build cef for desabled webrtc. preferably detailed.

Are you looking to disable it? The patch is only for linux right now. I am working on getting a windows patch should be ready tomorrow..
Last edited by kabone76 on Sun Oct 14, 2018 7:13 pm, edited 1 time in total.
kabone76
Techie
 
Posts: 19
Joined: Wed Oct 03, 2018 6:36 pm

Re: Where would I submit a patch?

Postby milannn » Tue Oct 16, 2018 4:35 pm

kabone76 wrote:
magreenblatt wrote:Such a patch should be submitted to Chromium. See https://groups.google.com/a/chromium.or ... yjcoAGEQAJ

Thanks I will check this out.

milannn wrote:Please tell me how you build cef for desabled webrtc. preferably detailed.

Are you looking to disable it? The patch is only for linux right now. I am working on getting a windows patch should be ready tomorrow..


Any news on the build for windows?
milannn
Newbie
 
Posts: 4
Joined: Sun Oct 14, 2018 11:03 am


Return to CEF Discussion

Who is online

Users browsing this forum: No registered users and 23 guests