How to *correctly* update chromium after a CEF rebase?

Do not post support requests, bug reports or feature requests. Discuss CEF here. Non-CEF related discussion goes in General Discussion!

How to *correctly* update chromium after a CEF rebase?

Postby ndesktop » Tue Aug 06, 2024 5:49 am

I am reading the Rebasing on Upstream Changes and I just successfully rebased 127.0.6533.57 to 127.0.6533.89.

But I am not sure (I looked quite thoroughly, but not finding something 100% clear) about what exactly do I have to run after CEF rebasing which affects the CHROMIUM_BUILD_COMPATIBILITY.txt.
Is it an a gclient sync? gclient sync --no-hooks? gclient sync --no-hooks --with_branch_heads? or the same automate-git.py command for checkout - mine being (part of a do-all script):
Code: Select all
python3 %ROOTDIR%\automate-git.py --url=%URL% --download-dir=%ROOTDIR% --branch=%CEF_BRANCH% --no-depot-tools-update --no-build --no-distrib --no-distrib-docs --no-distrib-archive --no-debug-tests --no-release-tests --with-pgo-profiles

and this will detect the Chromium hash change and run all the sync/hooks/etc. necessary?
ndesktop
Master
 
Posts: 821
Joined: Thu Dec 03, 2015 10:10 am

Re: How to *correctly* update chromium after a CEF rebase?

Postby magreenblatt » Tue Aug 06, 2024 8:07 am

This is what we use for Chromium updates: https://bitbucket.org/chromiumembedded/ ... the-update

Use the “update the checkout of an existing release branch” command-line. Remove the “chromium-checkout” flag if CHROMIUM_BUILD_COMPATIBILITY.txt is already updated to the target version.
magreenblatt
Site Admin
 
Posts: 12736
Joined: Fri May 29, 2009 6:57 pm

Re: How to *correctly* update chromium after a CEF rebase?

Postby ndesktop » Tue Aug 06, 2024 9:49 am

Thank you so much.
An observation:
Remove the “chromium-checkout” flag if CHROMIUM_BUILD_COMPATIBILITY.txt is already updated to the target version.

so it should remain (for 6533 branch I am working with)
Code: Select all
python automate-git.py [...] --no-build --fast-update --force-cef-update --branch=6533

Should not also --force-cef-update be removed (and perhaps replaced with --no-cef-update), since CEF was already rebased to the desired version?
ndesktop
Master
 
Posts: 821
Joined: Thu Dec 03, 2015 10:10 am

Re: How to *correctly* update chromium after a CEF rebase?

Postby magreenblatt » Tue Aug 06, 2024 10:05 am

You can remove --force-cef-update if you don’t need patch files updated. If your local CEF checkout is up-to-date you can use --no-cef-update. Both flags will likely be a no-op anyways in that case.
magreenblatt
Site Admin
 
Posts: 12736
Joined: Fri May 29, 2009 6:57 pm

Re: How to *correctly* update chromium after a CEF rebase?

Postby ndesktop » Tue Aug 06, 2024 10:08 am

Understood, thank you so much.
ndesktop
Master
 
Posts: 821
Joined: Thu Dec 03, 2015 10:10 am


Return to CEF Discussion

Who is online

Users browsing this forum: No registered users and 2 guests