Update 2357 Branch to 43.0.2357.124

Think CEF could benefit from a new feature or capability? Discuss CEF feature requests here.

Update 2357 Branch to 43.0.2357.124

Postby amaitland » Sat Jun 20, 2015 3:54 am

Is it possible to upgrade the 2357 branch to 43.0.2357.124?

Looking at https://bitbucket.org/chromiumembedded/ ... ?at=master I wasn't quite sure how the changes to the patch files were generated/maintained.

Point me in the correct direction and I'll happily create a PR.
Maintainer of the CefSharp project.
amaitland
Virtuoso
 
Posts: 1290
Joined: Wed Jan 14, 2015 2:35 am

Re: Update 2357 Branch to 43.0.2357.124

Postby magreenblatt » Sat Jun 20, 2015 2:46 pm

See https://bitbucket.org/chromiumembedded/ ... mUpdate.md for instructions. There's no need to submit a PR.
magreenblatt
Site Admin
 
Posts: 12382
Joined: Fri May 29, 2009 6:57 pm

Re: Update 2357 Branch to 43.0.2357.124

Postby amaitland » Sat Jun 20, 2015 5:41 pm

Thanks for the prompt reply. By creating a PR I was hoping to use the resulting build from cefbuilds.com

As background for the last ~12 months I've been maintaining the `CefSharp` project. Long and the short it greatly simplifies things if we can use a binary version sourced from cefbuilds.com

Any objection to upgrading the 2357 branch?
Maintainer of the CefSharp project.
amaitland
Virtuoso
 
Posts: 1290
Joined: Wed Jan 14, 2015 2:35 am

Re: Update 2357 Branch to 43.0.2357.124

Postby magreenblatt » Sun Jun 21, 2015 11:48 am

No objections but it won't occur until the 2nd week of July.
magreenblatt
Site Admin
 
Posts: 12382
Joined: Fri May 29, 2009 6:57 pm

Re: Update 2357 Branch to 43.0.2357.124

Postby amaitland » Mon Jul 06, 2015 4:52 am

I've tried and failed unfortunately, will have another go at some point.

The `patch_updater.py` keeps removing the patch file content, so I'm require clearly missing something.

Advise would be most welcome, otherwise I'll have another go when I get a chance.
Maintainer of the CefSharp project.
amaitland
Virtuoso
 
Posts: 1290
Joined: Wed Jan 14, 2015 2:35 am

Re: Update 2357 Branch to 43.0.2357.124

Postby magreenblatt » Mon Jul 06, 2015 12:15 pm

amaitland wrote:The `patch_updater.py` keeps removing the patch file content, so I'm require clearly missing something.

You forgot to add the `--resave` flag.
magreenblatt
Site Admin
 
Posts: 12382
Joined: Fri May 29, 2009 6:57 pm

Re: Update 2357 Branch to 43.0.2357.124

Postby amaitland » Mon Jul 06, 2015 5:15 pm

I see you've updated the branch. Thanks! Much appreciated.

magreenblatt wrote:You forgot to add the `--resave` flag.


I had run `--resave`. It appears my problems are more environment specific. My system wide python install was invoking `depot_tools\patch.py` as it had registered `.py` as a `pathext`, so it was being executed instead of `patch.exe`

magreenblatt wrote:No objections but it won't occur until the 2nd week of July.


Out of curiosity is there a reference that details the build schedule for cefbuilds.com?
Maintainer of the CefSharp project.
amaitland
Virtuoso
 
Posts: 1290
Joined: Wed Jan 14, 2015 2:35 am

Re: Update 2357 Branch to 43.0.2357.124

Postby magreenblatt » Mon Jul 06, 2015 5:46 pm

CEF has now been updated to 43.0.2357.130. Unfortunately the cefbuilds.com timing is not easy to predict.
magreenblatt
Site Admin
 
Posts: 12382
Joined: Fri May 29, 2009 6:57 pm

Re: Update 2357 Branch to 43.0.2357.124

Postby amaitland » Thu Jul 09, 2015 7:43 am

The `Windows 64bit` builds for both `trunk` and `2357` seem to be rather out of date. Is there any way to tell if there's a problem?
Maintainer of the CefSharp project.
amaitland
Virtuoso
 
Posts: 1290
Joined: Wed Jan 14, 2015 2:35 am

Re: Update 2357 Branch to 43.0.2357.124

Postby magreenblatt » Thu Jul 09, 2015 2:17 pm

amaitland wrote:The `Windows 64bit` builds for both `trunk` and `2357` seem to be rather out of date. Is there any way to tell if there's a problem?

Probably https://bitbucket.org/chromiumembedded/cef/issues/1647. A patch to fix that would be welcome (requires someone to run a local 64-bit Windows build to verify).
magreenblatt
Site Admin
 
Posts: 12382
Joined: Fri May 29, 2009 6:57 pm

Next

Return to Feature Request Forum

Who is online

Users browsing this forum: No registered users and 21 guests

cron